Skip site navigation (1) Skip section navigation (2)

Re: pg_upgrade problem with invalid indexes

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_upgrade problem with invalid indexes
Date: 2012-12-07 01:05:56
Message-ID: 50C140F4.5080204@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-hackers
On 12/06/2012 07:58 PM, Jeff Davis wrote:
> On Thu, 2012-12-06 at 16:31 -0800, Josh Berkus wrote:
>>> There are a few possible fixes.  The first would be to have pg_upgrade
>>> throw an error on any invalid index in the old cluster.  Another option
>>> would be to preserve the invalid state in pg_dump --binary-upgrade.
>> Or to not dump invalid indexes at all in --binary-upgrade mode.
> +1
>
> 	

I think I prefer the first suggestion. If they are trying to upgrade 
when there's an invalid index presumably they aren't aware of the 
invalidity (or they would have done something about it). It would be 
better to fail and make them fix or remove the index, ISTM.

cheers

andrew



In response to

Responses

pgsql-hackers by date

Next:From: Stephen FrostDate: 2012-12-07 01:12:27
Subject: Re: Commits 8de72b and 5457a1 (COPY FREEZE)
Previous:From: Jeff DavisDate: 2012-12-07 00:58:03
Subject: Re: pg_upgrade problem with invalid indexes

Privacy Policy | About PostgreSQL
Copyright © 1996-2013 The PostgreSQL Global Development Group