Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Add mode where contrib installcheck runs each module in a separa

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add mode where contrib installcheck runs each module in a separa
Date: 2012-12-03 21:02:37
Message-ID: 50BD136D.1020405@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On 12/03/2012 03:11 PM, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> On 12/03/2012 02:46 PM, Tom Lane wrote:
>>> I see this too.  Given that I want to wrap the back branches in a few
>>> minutes, please revert at least in the back branches.  I can't wait
>>> for you to sort this out.
>> OK. I reverted the lot.
> Thanks, appreciate it.  I'll help look into the problem late tonight,
> if it's not sorted by then, but I have no time right now ...


Looks like undefine is a new feature in gmake 3.82. I can reproduce this 
on my SL6 box which has 3.81. I'll have to come up with something other 
than ifdef, like

     ifneq ($(USE_MODULE_DB),)

and use the override in dblink's Makefile to set it to the empty string.


cheers

andrew



In response to

Responses

pgsql-hackers by date

Next:From: Alvaro HerreraDate: 2012-12-03 21:35:44
Subject: Re: Review: Extra Daemons / bgworker
Previous:From: Bruce MomjianDate: 2012-12-03 21:01:45
Subject: Re: --single-transaction hack to pg_upgrade does not work

pgsql-committers by date

Next:From: Andrew DunstanDate: 2012-12-04 00:17:36
Subject: Re: [COMMITTERS] pgsql: Add mode where contrib installcheck runs each module in a separa
Previous:From: Tom LaneDate: 2012-12-03 20:29:08
Subject: pgsql: Stamp 8.3.22.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group