Re: [PATCH] Make pg_basebackup configure and start standby [Review]

From: Boszormenyi Zoltan <zb(at)cybertec(dot)at>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Amit Kapila <amit(dot)kapila(at)huawei(dot)com>, 'Hans-Jürgen Schönig' <hs(at)cybertec(dot)at>, 'Pg Hackers' <pgsql-hackers(at)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Subject: Re: [PATCH] Make pg_basebackup configure and start standby [Review]
Date: 2012-10-04 16:19:36
Message-ID: 506DB718.4050309@cybertec.at
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2012-10-04 16:43 keltezéssel, Tom Lane írta:
> Boszormenyi Zoltan <zb(at)cybertec(dot)at> writes:
>>> Did you think about something like the attached code?
>> Or rather this one, which fixes a bug so fillPGconn() and PQconninfo() are
>> symmetric and work for "requiressl".
> That's incredibly ugly. I'm not sure where we should keep the "R"
> information, but shoehorning it into the existing PQconninfoOption
> struct like that seems totally unacceptable. Either we're willing to
> break backwards compatibility on the Disp-Char strings, or we need
> to put that info somewhere else.

I hope only handling the new flag part is ugly. It can be hidden
in the PQconninfoMapping[] array and PQconninfo(conn, true)
pre-filters the list as in the attached version.

Best regards,
Zoltán Böszörményi

--
----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt, Austria
Web: http://www.postgresql-support.de
http://www.postgresql.at/

Attachment Content-Type Size
01-PQconninfo-v9.patch text/x-patch 15.4 KB
02-pg_basebackup-v6.patch text/x-patch 6.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2012-10-04 16:23:06 Re: Sharing more infrastructure between walsenders and regular backends (was Re: Switching timeline over streaming replication)
Previous Message Tom Lane 2012-10-04 16:00:00 Re: Sharing more infrastructure between walsenders and regular backends (was Re: Switching timeline over streaming replication)