Skip site navigation (1) Skip section navigation (2)

Fix for broken JDBC's getColumn() (take 2)

From: Jeroen van Vianen <jeroen(dot)van(dot)vianen(at)satama(dot)com>
To: pgsql-jdbc(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Fix for broken JDBC's getColumn() (take 2)
Date: 2001-09-10 18:00:39
Message-ID: 5.1.0.14.2.20010910194701.00acbab0@ams010.satama.com (view raw or flat)
Thread:
Lists: pgsql-jdbcpgsql-patches
Hi,

Per the recent discussion there's been some code changes in JDBC's 
DatabaseMetaData.getColumn(). I proposed a patch that would change the 
number of queries to find out all columns in a table from 2 * N + 1 to 1 (N 
being the number of columns reported) by using some outer joins. I also 
fixed the fact that getColumns() only returned columns that had a default 
defined. OTOH, I did not use to change the code required for obtaining a 
column's remarks (by using col_description() for 7.2  and requested by Tom 
Lane).

Finally, I have found a way to get all the column details in a single query 
*and* use col_description() for 7.2 servers. A patch is attached. It 
overrules René Pijlman's fix for this that was committed just today, but 
still used N + 1 queries (sorry René ;-) )

I also fixed the return values for TABLE_CAT and TABLE_SCHEM from "" to 
null, to be more standard compliant (and requested in René's mail found at 
http://fts.postgresql.org/db/mw/msg.html?mid=1034253).

As always, the JDBC1 version has not been tested as I have no JDK 1.1 
available.

Please review,


Jeroen

Attachment: DatabaseMetaData.diff.gz
Description: application/octet-stream (3.1 KB)

Responses

pgsql-patches by date

Next:From: Peter EisentrautDate: 2001-09-11 00:13:23
Subject: Re: Support building in a different directory on Solaris
Previous:From: Peter EisentrautDate: 2001-09-10 17:58:55
Subject: Re: Configuring fdatasync for Solaris2

pgsql-jdbc by date

Next:From: Culley HarrelsonDate: 2001-09-11 03:12:48
Subject: Fwd: Re: unicode in 7.1
Previous:From: Bruce MomjianDate: 2001-09-10 15:08:01
Subject: Re: Fix DatabaseMetaDataTest in JDBC test suite

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group