Re: [INTERFACES] Re: [PATCHES] Re: Fixes and enhancements to JDBC driver(take 2)

From: Peter Mount <peter(at)retep(dot)org(dot)uk>
To: Richard Bullington-McGuire <rbulling(at)microstate(dot)com>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Barry Lind <barry(at)xythos(dot)com>, Gunnar R|nning <gunnar(at)candleweb(dot)no>, PostgreSQL jdbc list <pgsql-jdbc(at)postgresql(dot)org>
Subject: Re: [INTERFACES] Re: [PATCHES] Re: Fixes and enhancements to JDBC driver(take 2)
Date: 2001-02-03 11:20:57
Message-ID: 5.0.2.1.0.20010203111908.009f6790@mail.retep.org.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc

At 09:30 02/02/01 -0500, Richard Bullington-McGuire wrote:
>On Fri, 2 Feb 2001, Peter T Mount wrote:
>
> > > What is the final resolution of this for 7.1? I noticed that you have
> > > essentially commented out the byte array pooling code in current
> > > sources. Given that 7.1 is rapidly coming to a close, is this
> > > something
> > > that is expected to get fixed and reenabled for 7.1, or is this going
> > > to wait for 7.2.
> >
> > I commented it out to make sure that when 7.1 was released the driver
> > would at least work (with it enabled we would have one broken driver).
>
>At Microstate, we fixed the byte pooling code when it was still in
>PG_Stream. We patched this and submitted our patch to pgsql-patches, and
>it was accepted. It did have some nasty off-by-one errors. It does not
>look like the fixes we did made it into the new, separate
>org.postgresql.core.BytePoolDim[12] classes.

Hmmm, should have as I remember puting your fixes in. I remember this as I
had to apply the patch manually as I did it while moving the code out of
PG_Stream. I'll double check.

>We've been using this code on an application with many tens of thousands
>of queries per day for more than a month without any problems.
>
>I've attached the production PG_Stream.java class that we've been using.

Thanks.

In response to

Browse pgsql-jdbc by date

  From Date Subject
Next Message Srikanth Rao 2001-02-03 22:34:16 When will LargeObject.getInputStream() be implemented?
Previous Message Bruce Momjian 2001-02-02 17:55:14 Re: Re: [INTERFACES] Re: [PATCHES] Re: Fixes and enhancements to JDBC driver(take 2)