Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags
Date: 2010-12-12 17:22:09
Message-ID: 4D0504C1.5080406@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 12/12/2010 11:16 AM, Tom Lane wrote:
>
> I put in #define's for these, and it seems to have fixed the MSVC
> buildfarm members, but cygwin is still broken. How come ... doesn't
> that port use port/win32.h?
>

ITYM Mingw. And yes, it does use port/win32.h; narwhal's log says:

config.status: linking src/include/port/win32.h to src/include/pg_config_os.h

cheers

andrew

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2010-12-12 17:37:37 Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags
Previous Message Tom Lane 2010-12-12 16:16:46 Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-12-12 17:37:37 Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags
Previous Message Florian Pflug 2010-12-12 17:16:29 Re: Problem with pg_upgrade (8.4 -> 9.0) due to ALTER DATABASE SET ROLE