Skip site navigation (1) Skip section navigation (2)

Re: Fwd: Pgadmin 1.12 rc1 editing bug

From: Steffen Kuhn <pg(at)kuhnsteffen(dot)de>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Fwd: Pgadmin 1.12 rc1 editing bug
Date: 2010-09-03 20:24:25
Message-ID: 4C815979.1080400@kuhnsteffen.de (view raw or flat)
Thread:
Lists: pgadmin-hackers
  Hi Guillaume,

the delete problem is following:
deleting rows has got the shortcut 'del'. Disabeling row deletion 
disables 'del'.
Even the key event WXK_DELETE is not fired.
So the solution of this problem which should been there since 'del' is 
the shortcut for row delete
is to change the shortcut to eg. 'ctrl-del', to get the default behavior 
of the del key.
Could you please comment this.

Working on this I located other issues in the edit context:
_Select some text use context menu an try to perform an action.
Nothing happens, because as I assume selection and focus is lost while 
opening the conext menu.
_Select a numeric value and use context menu. A totally different 
context menu occurs (system context menu includeing unicode input 
features, icons etc.),
which I know from situations in which no menu was defined.

For the shortcut issue I attach a patch.
The new rest will take some time, because for newbie eyes this looks not 
trivial.

Regards Steffen

On 03.09.2010 17:12, Guillaume Lelarge wrote:
> Le 03/09/2010 17:08, Steffen Kuhn a écrit :
>>   Okay I'll do my best. ;-)
>>
> Thanks. That gives me more time for the GSoC. I really appreciate that.
>
>> Did I get you right to just perform a delete for to current text
>> selection or the letter after the cursor
> Yes.
>
>> and not enabling menu and toolbar (commented with 'Delete selected
>> rows.') ?
>>
> The icon on the toolbar is not at fault here. It's a delete row button,
> and it should stay that way.
>
> The Delete item in the Edit menu should be enabled when an editor is
> open. And disabled otherwise.
>
>


Attachment: del.work.patch
Description: text/x-patch (1.3 KB)

In response to

Responses

pgadmin-hackers by date

Next:From: Dave PageDate: 2010-09-03 21:07:07
Subject: Re: Fwd: Pgadmin 1.12 rc1 editing bug
Previous:From: Guillaume LelargeDate: 2010-09-03 15:12:11
Subject: Re: Fwd: Pgadmin 1.12 rc1 editing bug

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group