Skip site navigation (1) Skip section navigation (2)

Re: Review: Re: [PATCH] Re: [HACKERS] Adding xpath_exists function

From: Mike Fowler <mike(at)mlfowler(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: David Fetter <david(at)fetter(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Round Robin Reviewers <pgsql-rrreviewers(at)postgresql(dot)org>
Subject: Re: Review: Re: [PATCH] Re: [HACKERS] Adding xpath_exists function
Date: 2010-08-07 15:38:06
Message-ID: 4C5D7DDE.5070408@mlfowler.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-rrreviewers
On 06/08/10 20:55, Peter Eisentraut wrote:
> On fre, 2010-08-06 at 09:04 +0100, Mike Fowler wrote:
>> If the patch is to be committed, does it make sense for me to refine
>> it such that it uses the new xpath internal function you extracted in
>> the xmlexists patch?
>
> Yes, you can probably shrink this patch down to about 20 lines.
>

Updated the patch so that it will apply to head and re-worked the 
function to use the new xpath internal function.

Regards,

-- 
Mike Fowler
Registered Linux user: 379787

Attachment: xpath_exists-4.patch
Description: text/x-diff (11.1 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Mike FowlerDate: 2010-08-07 15:47:17
Subject: Re: review: xml_is_well_formed
Previous:From: Tom LaneDate: 2010-08-07 14:36:23
Subject: Re: gincostestimate

pgsql-rrreviewers by date

Next:From: Tom LaneDate: 2010-08-08 19:18:17
Subject: Re: Review: Re: [PATCH] Re: [HACKERS] Adding xpath_exists function
Previous:From: Peter EisentrautDate: 2010-08-06 19:55:05
Subject: Re: Review: Re: [PATCH] Re: [HACKERS] Adding xpath_exists function

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group