Re: [COMMITTERS] pgsql: Clean up package namespace use and use of Safe in plperl.

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Tim Bunce <Tim(dot)Bunce(at)pobox(dot)com>, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [COMMITTERS] pgsql: Clean up package namespace use and use of Safe in plperl.
Date: 2010-02-17 05:35:16
Message-ID: 4B7B8014.6090807@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Tom Lane wrote:
> adunstan(at)postgresql(dot)org (Andrew Dunstan) writes:
>
>> Clean up package namespace use and use of Safe in plperl.
>>
>
> According to buildfarm member kite, there is more than one spelling of
> the Perl warning message that was (randomly?) chosen for the test added
> here. I doubt it's worth maintaining a variant expected file for this
> --- I'd suggest picking a simpler warning or dropping the actual
> warning-generation aspect of the test.
>
>
>

Thanks for the report. I have committed a test that I hope will have a
more portable message.

cheers

andrew

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2010-02-17 05:51:40 pgsql: Another typo fix.
Previous Message Andrew Dunstan 2010-02-17 05:32:49 pgsql: Use a fatal warning check with what looks like a more portable

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2010-02-17 05:55:41 Re: Streaming replication on win32, still broken
Previous Message Tom Lane 2010-02-17 05:24:41 Re: Listen / Notify - what to do when the queue is full