Skip site navigation (1) Skip section navigation (2)

Re: Ticket 117: Explain Buffers

From: Euler Taveira de Oliveira <euler(at)timbira(dot)com>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Ticket 117: Explain Buffers
Date: 2010-01-26 03:13:12
Message-ID: 4B5E5DC8.7030706@timbira.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
Guillaume Lelarge escreveu:
> New patch attached.
> 
Nice job. But there are just a few gripes about your patch: (i) it doesn't
disable the EXPLAIN button when the BUFFERS option is enabled, (ii) it doesn't
disable the EXPLAIN ANALYZE menu when the query is running, and (iii) there is
a bug when the BUFFERS option is enabled and you close and open the query tool
again (the EXPLAIN menu turns enabled instead of disabled).

The attached patch (on the top of your patch) addresses all of these problems.


-- 
  Euler Taveira de Oliveira
  http://www.timbira.com/

Attachment: x.diff
Description: text/x-patch (1.9 KB)

In response to

Responses

pgadmin-hackers by date

Next:From: Guillaume LelargeDate: 2010-01-26 09:18:14
Subject: Re: Ticket 117: Explain Buffers
Previous:From: Guillaume LelargeDate: 2010-01-25 22:47:45
Subject: Re: Ticket 117: Explain Buffers

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group