Re: point_ops for GiST

From: Teodor Sigaev <teodor(at)sigaev(dot)ru>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: point_ops for GiST
Date: 2010-01-11 17:57:18
Message-ID: 4B4B667E.2010305@sigaev.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> I have reviewed this patch and it looks good to me. The only
> substantive question I have is why gist_point_consistent() uses a
> different coding pattern for the box case than it does for the polygon
> and circle cases? It's not obvious to me on the face of it why these
> aren't consistent.

gist_circle_consistent/gist_poly_consistent set recheck flag to true because
corresponding index contains only bounding box of indexed values
(circle/polygon). gist_point_consistent could do an exact check. Will add a coments.

> Beyond that, I have a variety of minor whitespace and commenting
> suggestions, so I am attaching an updated version of the patch as well

Agree with your changes. Suppose, there is no objection to commit it?

--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Teodor Sigaev 2010-01-11 18:08:43 Re: Red-black tree for GIN
Previous Message Tom Lane 2010-01-11 17:54:10 Re: pg_dump sort order for functions