Re: [PATCH] Provide rowcount for utility SELECTs

From: Boszormenyi Zoltan <zb(at)cybertec(dot)at>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Hans-Juergen Schoenig <hs(at)cybertec(dot)at>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Provide rowcount for utility SELECTs
Date: 2009-12-29 07:50:49
Message-ID: 4B39B4D9.4000407@cybertec.at
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane írta:
> Boszormenyi Zoltan <zb(at)cybertec(dot)at> writes:
>
>> Tom Lane írta:
>>
>>> It's more the possibility of doing strcmp(tag, "SELECT") on the command
>>>
>
>
>> Actually it's strncmp(tag, "SELECT ", 7), so when you mix old server
>> with new clients or new server with old client, it will just work as
>> before, i.e. return "".
>>
>
> Are you deliberately ignoring the point?

No, I just thought you were commenting on my patch's details...

> We have no way to know whether
> there is any client-side code that's doing a simple check for SELECT
> command tag, but it's certainly possible. The fact that it wouldn't be
> hard to fix does not mean that it wouldn't be broken.
>
> regards, tom lane
>
>

--
Bible has answers for everything. Proof:
"But let your communication be, Yea, yea; Nay, nay: for whatsoever is more
than these cometh of evil." (Matthew 5:37) - basics of digital technology.
"May your kingdom come" - superficial description of plate tectonics

----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
http://www.postgresql.at/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Boszormenyi Zoltan 2009-12-29 07:58:14 Re: [PATCH] Provide rowcount for utility SELECTs
Previous Message Tatsuo Ishii 2009-12-29 06:22:31 Re: exec_execute_message crush