Re: HAVE_FSEEKO for WIN32

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: HAVE_FSEEKO for WIN32
Date: 2009-01-07 13:56:14
Message-ID: 4964B47E.40106@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan wrote:
>
>
> Magnus Hagander wrote:
>> Bruce Momjian wrote:
>>
>>> Andrew Dunstan wrote:
>>>
>>>> Cleaning up the parallel restore patch I came across a question I
>>>> might have asked before, but one which in any case I worked around:
>>>>
>>>> Why do we carefully define fseeko() for WIN32 but then not define
>>>> HAVE_FSEEKO, which makes doing the former pretty much pointless?
>>>>
>>> With Andrew, I have developed and applied the attached patch so MinGW
>>> handles fseeko() translation similar to Unix.
>>>
>>> Someone will need to update MSVC to have similar behavior.
>>>
>>
>> Which is what? :-)
>>
>> It just needs to set HAVE_FSEEKO to 1 in pg_config.h?
>>
>>
>>
>
> Yep. I have fixed it already.

Ok, thanks!

//Magnus

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Joshua Tolley 2009-01-07 14:14:17 Re: Proposed Patch to Improve Performance of Multi-BatchHash Join for Skewed Data Sets
Previous Message Magnus Hagander 2009-01-07 13:55:42 Re: [BUGS] BUG #4186: set lc_messages does not work