Re: pgsql: Reduce risk of accidentally running temp-install regression tests

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Peter Eisentraut <petere(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Reduce risk of accidentally running temp-install regression tests
Date: 2008-11-28 21:24:31
Message-ID: 4930618F.3000307@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Peter Eisentraut wrote:
> Log Message:
> -----------
> Reduce risk of accidentally running temp-install regression tests against
> a mismatching installation. Pick a default port number calculated from the
> version number, and try a few times with other numbers if that one doesn't
> work. Check if we can connect to the port before starting our own postmaster,
> to detect some other server already running there. To simplify the code,
> drop --temp-port option and use --port for both temp-install and pre-installed
> case.
>
> Modified Files:
> --------------
> pgsql/src/test/regress:
> GNUmakefile (r1.75 -> r1.76)
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/GNUmakefile?r1=1.75&r2=1.76)
> pg_regress.c (r1.53 -> r1.54)
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/pg_regress.c?r1=1.53&r2=1.54)
>
>

This has apparently broken the ECPG tests - see buildfarm where multiple
members are red.

cheers

andrew

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2008-11-28 22:08:42 Re: Re: [COMMITTERS] pgsql: Add support for matching wildcard server certificates to the new
Previous Message Tom Lane 2008-11-28 21:19:13 pgsql: Fix an oversight in uninstall_isn.sql: must drop operator