Skip site navigation (1) Skip section navigation (2)

Re: Patch for ALTER DATABASE WITH TABLESPACE

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Bernd Helmle <mailings(at)oopsware(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch for ALTER DATABASE WITH TABLESPACE
Date: 2008-11-07 08:51:13
Message-ID: 49140181.3000903@lelarge.info (view raw or flat)
Thread:
Lists: pgsql-hackers
Bernd Helmle a écrit :
> --On Donnerstag, November 06, 2008 11:35:54 +0100 Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
> 
>> Guillaume Lelarge a écrit :
>>> v4 patch attached.
>>>
>>
>> v5 patch attached.
>>
> 
> Thanks Guillaume.
> 
> Maybe this is nit-picking, but i see that you have to rmdir() an
> existing empty tablespace directory to use copydir() afterwards. Maybe
> we can teach copydir() to error out when trying to mkdir() an existing
> directory only when forced by the caller? I see copydir() used at four
> places, so the impact of this change would be minimal.
> 

I don't think this is nit-picking. I think about it too myself when I
did v4 and v5. I wasn't so sure, I prefered not to change this function
because it's used on important parts of the code (createdb and redo wal).

Anyway, I did what you asked. v6 is attached.

Thanks.


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

Attachment: alterdb_tablespace_v6.patch.bz2
Description: application/x-bzip (5.3 KB)

In response to

Responses

pgsql-hackers by date

Next:From: KaiGai KoheiDate: 2008-11-07 09:20:49
Subject: Updates of SE-PostgreSQL 8.4devel patches (r1197)
Previous:From: Simon RiggsDate: 2008-11-07 08:49:40
Subject: Re: Walsender process patch v1 for Synch Rep

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group