Skip site navigation (1) Skip section navigation (2)

Re: Synchronous replication patch v1

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Synchronous replication patch v1
Date: 2008-10-31 13:15:35
Message-ID: 490B04F7.90405@enterprisedb.com (view raw or flat)
Thread:
Lists: pgsql-hackers
Fujii Masao wrote:
> And, there are some problems in this patch;
> 
> * This patch is somewhat big, though it should be subdivided for
>    review.
> 
> * Source code comments and documents are insufficient.
> 
> Is it against the rule of commit fest to add such a status patch
> into review-queue? If so, I would aim for 8.5. Otherwise,
> I will deal with the problems also during commit fest.
> What is your opinion?

You can add work-in-progress patches and even just design docs to the 
commitfest queue. That's perfectly OK. They will be reviewed as any 
other work, but naturally if it's not a patch that's ready to be 
committed without major work, it won't be committed.

I haven't looked at the patch yet, but if you think there's chances to 
get it into shape for inclusion to 8.4, before the commit fest is over, 
you can and should keep working on it and submit updated patches during 
the commit fest. However, help with reviewing other patches would also 
be very much appreciated. The idea of commitfests is that everyone stops 
working on their own stuff, except for cleaning up and responding to 
review comments on one's own patches that are in the queue, and helps to 
review other people's patches.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

In response to

Responses

pgsql-hackers by date

Next:From: Teodor SigaevDate: 2008-10-31 13:27:22
Subject: Re: [PATCHES] GIN improvements
Previous:From: Peter EisentrautDate: 2008-10-31 12:37:28
Subject: Distinct types

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group