Skip site navigation (1) Skip section navigation (2)

Re: page macros cleanup (ver 04)

From: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
To: Heikki Linnakangas <heikki(at)enterprisedb(dot)com>
Cc: Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: page macros cleanup (ver 04)
Date: 2008-07-09 13:43:59
Message-ID: 4874C09F.4000302@sun.com (view raw or flat)
Thread:
Lists: pgsql-patches
Heikki Linnakangas napsal(a):
> Zdenek Kotala wrote:
>> Pavan Deolasee napsal(a):

> There's another academical discrepancy between these two hunks:

<snip>

> I admit I don't understand what that bitmap is, it looks like we're 
> assuming it can take up all the space between page header and the 
> special portion, without any line pointers, but in HashPageGetBitmap, 
> we're reserving space for one pointer. It looks like the actual size of 
> the bitmap is only the largest power of 2 below the maximum size, so 
> that won't be an issue in practice. That macro is actually doing the 
> same thing as PageGetContents, so I switched to using that. As that 
> moves the data sligthly on those bitmap pages, I guess we'll need a 
> catversion bump.

Good catch. if we have to bump catalog version then I have there small patch
which introduce following macro and remove PageHeaderData stucture from 
HashMetaPageData:

#define HashPageGetMeta(page) ((HashMetaPage) (PageGetContents(page)))

It also needs bump a catalog version and if we do it now I think it is better to
connect both these patches and do bump only once.

> Attached is an updated patch. I also fixed some whitespace and comments 
> that were no longer valid. How does it look to you now?

Perfect. Thanks

		Zdenek






Attachment: hash.patch
Description: text/x-patch (7.1 KB)

In response to

Responses

pgsql-patches by date

Next:From: Josh BerkusDate: 2008-07-09 17:55:24
Subject: Re: [PATCHES] Solaris ident authentication using unix domain sockets
Previous:From: Heikki LinnakangasDate: 2008-07-09 11:54:08
Subject: Re: page macros cleanup (ver 04)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group