Skip site navigation (1) Skip section navigation (2)

Re: libpq object hooks

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Merlin Moncure <mmoncure(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Chernow <ac(at)esilo(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: libpq object hooks
Date: 2008-05-16 15:21:15
Message-ID: 482DA66B.4000901@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches

Merlin Moncure wrote:
>   
>> Also, even if varargs are safe they'd be notationally unpleasant
>> in the extreme.  varargs are just a PITA to work with --- you'd have
>> to do all the decoding in the first-level hook routine, even for
>> items you weren't going to use.  With something like the above
>> all you need is a switch() and some pointer casts.
>>     
>
> Switch, plus struct (basically a union) will do the trick nicely.  Can
> it be a formal union, or is it better as a void*?
>
> The main issue was how what we called the 'hook data' was passed back
> and forth.  We'll get a patch up.
>
>
>   

All of this is getting quite a long way from what was in the commitfest 
queue. Do we still want to try to get this in this cycle, or should it 
be marked returned to author for more work?

cheers

andrew

In response to

Responses

pgsql-hackers by date

Next:From: Peter EisentrautDate: 2008-05-16 15:21:19
Subject: Re: ecpg localization
Previous:From: Merlin MoncureDate: 2008-05-16 15:13:43
Subject: Re: libpq object hooks

pgsql-patches by date

Next:From: Tom LaneDate: 2008-05-16 15:24:10
Subject: Re: libpq object hooks
Previous:From: Merlin MoncureDate: 2008-05-16 15:13:43
Subject: Re: libpq object hooks

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group