Skip site navigation (1) Skip section navigation (2)

Re: Proposed patch - psql wraps at window width

From: Bryce Nesbitt <bryce2(at)obviously(dot)com>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Proposed patch - psql wraps at window width
Date: 2008-04-18 06:36:14
Message-ID: 4808415E.5080905@obviously.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches

Alvaro Herrera wrote:
> * Don't lose warning comments like this one (unless you've removed the
> assumption of course)
>
> /*
>  * Assumption: This code used only on strings
>  * without multibyte characters, otherwise
>  * this_line->width < strlen(this_ptr) and we get
>  * an overflow
>  */
In fact, that particular assumption was causing a problem, causing a 
segfault.  I can't be certain, because the multibyte stuff is pretty 
intense, but I think I nailed it.  Thanks for all your comments!


In response to

pgsql-hackers by date

Next:From: Bryce NesbittDate: 2008-04-18 06:44:46
Subject: Coding standards
Previous:From: Martijn van OosterhoutDate: 2008-04-18 06:34:49
Subject: Re: Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout

pgsql-patches by date

Next:From: Bryce NesbittDate: 2008-04-18 06:44:46
Subject: Coding standards
Previous:From: Martijn van OosterhoutDate: 2008-04-18 06:34:49
Subject: Re: Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group