Skip site navigation (1) Skip section navigation (2)

Re: [BUGS] BUG #4186: set lc_messages does not work

From: "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>
To: "Hiroshi Inoue" <inoue(at)tpf(dot)co(dot)jp>,"Bruce Momjian" <bruce(at)momjian(dot)us>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>,"Magnus Hagander" <magnus(at)hagander(dot)net>,"Thomas H(dot)" <me(at)alternize(dot)com>,"PG Hackers" <pgsql-hackers(at)postgresql(dot)org>,"Gevik Babakhani" <pgdev(at)xs4all(dot)nl>
Subject: Re: [BUGS] BUG #4186: set lc_messages does not work
Date: 2009-01-06 16:35:04
Message-ID: 4601B834946C43C585DD02FB95AFB59A@HIRO57887DE653 (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-hackers
Hi.

Sorry very late reaction....

I report the test checked again. 
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/libintl_check/LC_MESSAGES_01.png
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/libintl_check/LC_MESSAGES_02.png
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/libintl_check/LC_MESSAGES_03.png
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/libintl_check/LC_MESSAGES_04.png
and
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/libintl_check/LC_MESSAGES.sql
Then, set PGCLIENTENCODING=SJIS
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/libintl_check/LC_MESSAGES.log

However, libintl needs to be created correctly.(Inoue-san prepares this.)
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/libintl_check/bin/
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/libintl_check/include/
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/libintl_check/lib/

in CVS-HEAD of the newest patch, line positions differ for a while.(.Inoue-san prepares this.)
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/libintl_check/mbutils_2.patch
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/libintl_check/win_lc_messages_2.patch

Conclusion, looks at a good result.!!

Regards,
Hiroshi Saito

----- Original Message ----- 
From: "Hiroshi Inoue" <inoue(at)tpf(dot)co(dot)jp>


> Oops, I forgot to attach the patch, sorry.
> 
> Hiroshi Inoue wrote:
>> Hi,
>> 
>> I posted a patch 18 days ago but have got no responce.
>> Anyway I've simplified the patch by using an appropriate
>>  gettext module.
>> 
>> Hiroshi Inoue wrote:
>>> Bruce Momjian wrote:
>>>> Tom Lane wrote:
>>>>> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>>>>>> Thomas H. wrote:
>>>>>>> so at least that explains the "changed" behaviour. nevertheless, 
>>>>>>> LC_MESSAGES seems to be defunct - with the "locale" folder present,
>>>>>>> pg always picks the os' language and ignores the lc_message value.
>>>>>> This looks like I can reproduce though, at least on cvs head. Did this
>>>>>> work for you in previous versions?
>>>>> Maybe we were using a different build of gettext in the previous
>>>>> releases, one that didn't look at the same info as the current code?
>>>>>
>>>>
>>>> Where are we on this?
>> 
>> AFAICS there are 2 causes.
>> 
>> 1. MSVC version of postgres is using a bad gettext module.
>> 2. getenv() in mingw cannot see the result of putenv() in MSVC8.0.
>> 
>> As for 1, we have to use another gettext module. I can provide it
>> if requested.
>> As for 2, pg_putenv() or pg_unsetenv() in the attachced patch calls 
>> corresponding putenv() whose result can be referenced by getenv() in
>>  mingw.
>> 
>> In addtion the patch provides a functionality to Windows locale
>> name to ISO formatted locale name.
>> 
>> Comments ?
>> 
>> regards,
>> Hiroshi Inoue
>

In response to

pgsql-hackers by date

Next:From: Robert HaasDate: 2009-01-06 16:46:23
Subject: Re: Warning about the 8.4 release
Previous:From: Kevin GrittnerDate: 2009-01-06 16:33:49
Subject: Re: incoherent view of serializable transactions

pgsql-bugs by date

Next:From: Kris JurkaDate: 2009-01-07 05:32:36
Subject: Re: BUG #4598: flaw in hashCode() method implementation of Connection class in postgresql-8.3-604.jdbc3.jar
Previous:From: Joshua TolleyDate: 2009-01-06 14:37:11
Subject: Re: BUG #4601: Data saving and opening problem

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group