Skip site navigation (1) Skip section navigation (2)

Re: Constraint trigger doc patch

From: Michael Paesold <mpaesold(at)gmx(dot)at>
To: Michael Glaesemann <grzm(at)myrealbox(dot)com>
Cc: pgsql-patches Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Constraint trigger doc patch
Date: 2006-10-16 17:20:45
Message-ID: 4533BF6D.8030201@gmx.at (view raw or flat)
Thread:
Lists: pgsql-patches
[Added pgsql-hackers to CC:]

Michael Glaesemann wrote:
[ a patch for constraint trigger docs]

Great! I was just going to try to use constraint triggers (because I 
needed deferrable constraints). So I personally appreciate this 
documentation update very much.

Just some notes:

> Index: doc/src/sgml/ref/create_constraint.sgml
...
> --- 21,32 ----
>    <refsynopsisdiv>
>   <synopsis>
>   CREATE CONSTRAINT TRIGGER <replaceable 
> class="parameter">name</replaceable>
> !     AFTER <replaceable class="parameter">event [ OR ... ]</replaceable>
> !     ON <replaceable class="parameter">table_name</replaceable>
> !     [ FROM <replaceable 
> class="parameter">referenced_table_name</replaceable> ]
> !     { NOT DEFERRABLE | [ DEFERABBLE ] { INITIALLY IMMEDIATE | 
> INITIALLY DEFERRED } }
> !     FOR EACH ROW
> !     EXECUTE PROCEDURE <replaceable 
> class="parameter">funcname</replaceable> ( <replaceable 
> class="parameter">arguments</replaceable> )
>   </synopsis>
>    </refsynopsisdiv>

It's spelled DEFERRABLE. You got it right in NOT DEFERRABLE but wrong in 
[ DEFERABBLE ].

 > The name of the constraint trigger. The actual name of the
 > created trigger will be of the form
 > <literal>RI_ConstraintTrigger_0000<literal> (where 0000 is some number
 > assigned by the server). Use this assigned name is when dropping the
 > constraint.

It think you should drop the "is" from the last sentence here. 
Additionally, I would prefer "Use this assigned name when dropping the 
trigger." here, because this one confused me to try to "ALTER TABLE DROP 
CONSTRAINT" instead of "DROP TRIGGER".

Thanks again.

Best Regards,
Michael Paesold


In response to

Responses

pgsql-patches by date

Next:From: Bruce MomjianDate: 2006-10-16 19:31:09
Subject: Re: Constraint trigger doc patch
Previous:From: Peter EisentrautDate: 2006-10-16 17:01:33
Subject: Re: [GENERAL] ISO week dates

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group