Re: [HACKERS] Possible explanation for Win32 stats regression

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: "korryd(at)enterprisedb(dot)com" <korryd(at)enterprisedb(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Possible explanation for Win32 stats regression
Date: 2006-07-29 20:15:53
Message-ID: 44CBC1F9.7050904@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

korryd(at)enterprisedb(dot)com wrote:
>> heh. I was just doing it the way Tom suggested - see attached. With a
>> little more trouble we could also keep track if the listened for events
>> and sometimes save ourselves a second call to WSAEventSelect, but I'm
>> not sure it's worth it.
>>
>
> It all depends on the overhead of WSAEventSelect(). I'm sure your version would run faster, but I just don't know if "slower" would be measurable.
>
>
> BTW: I would suggest changing your comment to:
>
> /*
> * make sure we don't multiplex this kernel event object with a
> different socket
> * from a previous call
> */
>
> Thanks for tackling this problem too.
>

Ok. Applied to HEAD and 8.1 and 8.0 branches.

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-07-29 22:38:12 Re: [HACKERS] pg_regress breaks on msys
Previous Message Hannu Krosing 2006-07-29 19:56:46 Re: Formulating an sql query with CTID

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-07-29 22:38:12 Re: [HACKERS] pg_regress breaks on msys
Previous Message korryd@enterprisedb.com 2006-07-29 19:35:08 Re: [HACKERS] Possible explanation for Win32 stats