Skip site navigation (1) Skip section navigation (2)

Re: Allow commenting of variables in postgresql.conf to -

From: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
To: Joachim Wieland <joe(at)mcknight(dot)de>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Allow commenting of variables in postgresql.conf to -
Date: 2006-06-01 14:56:10
Message-ID: 447F000A.3020101@sun.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Thanks, You have right. It is problem with silent skip some option in 
set_config_option function when  PGC_SIGHUP is running context.

I fix it and I attach third version of patch.

       Zdenek



Joachim Wieland wrote:
> Zdenek,
>
> On Wed, May 31, 2006 at 06:13:04PM +0200, Zdenek Kotala wrote:
>   
>> Joachim, could you explain me second point? I  cannot determine 
>> described problem. By my opinion my patch does not change this behavior.
>>     
>
> I guess what I saw was another phenomenon:
>
> I do the following:
>
> - vi postgresql.conf => "allow_system_table_mods = true"
> - start postmaster
> - vi postgresql.conf => "# allow_system_table_mods = true" (commented)
> - killall -HUP postmaster
>
> Then I get _no_ message. After another killall -HUP I do indeed get a
> message. So I don't get it just for the first time which is strange, do you
> see that as well?
>
> However the message I get is that it got reset to its default value which is
> wrong because its a PGC_POSTMASTER variable that can only be set at server
> start (set_config_option() returns true in this case as well).
>
> Consequently I expect to get it for every other signal I send (because the
> old value is still active and differs from what is in the configuration
> file).
>
>
> Joachim
>
>   


Attachment: pg_conf_3.patch
Description: text/x-patch (13.9 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Tzahi FadidaDate: 2006-06-01 15:17:44
Subject: Re: CTID issues and a soc student in need of help
Previous:From: Tom LaneDate: 2006-06-01 13:35:43
Subject: Re: [PATCH] Improve EXPLAIN ANALYZE overhead by sampling

pgsql-patches by date

Next:From: Tom LaneDate: 2006-06-01 15:00:12
Subject: Re: TODO-Item: full timezone names
Previous:From: Tom LaneDate: 2006-06-01 13:35:43
Subject: Re: [PATCH] Improve EXPLAIN ANALYZE overhead by sampling

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group