Re: AC_REPLACE_FUNCS([getaddrinfo]) in 8.1.3

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: AC_REPLACE_FUNCS([getaddrinfo]) in 8.1.3
Date: 2006-02-24 13:06:43
Message-ID: 43FF04E3.7080209@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:

>Albert Chin <pgsql-hackers(at)mlists(dot)thewrittenword(dot)com> writes:
>
>
>>On Sun, Feb 19, 2006 at 11:32:53PM -0500, Tom Lane wrote:
>>
>>
>>>Would you try the patch proposed at
>>>http://archives.postgresql.org/pgsql-patches/2006-01/msg00299.php
>>>
>>>
>
>
>
>>Works fine on Tru64 UNIX 4.0D and 5.1.
>>
>>
>
>OK, applied to HEAD and 8.1. I'm feeling a bit of concern though after
>re-reading the comment attached to the test:
>
># (Note: the AC_TRY_LINK probe fails on Windows, where the available
># versions of getaddrinfo don't follow normal C call protocol. This is OK
># because we want to use our own getaddrinfo.c on Windows anyway.)
>
>It seems likely that the new coding will allow the test to *succeed* on
>Windows. Does that happen, and if so is it bad? We can put in a hack
>to suppress the test on Windows if necessary. Someone please check it
>out on Windows ...
>
>
>
>

It would be bad - the whole thing is that on Windows we need to search
for some functions dynamically, so we have to use our own code to do that.

But it appears not to find it either with ipv6 installed or not. So I
think we're good (fingers crossed).

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nauman Naeem 2006-02-24 13:25:13 User privileges-verification required
Previous Message Rafael Martinez Guerrero 2006-02-24 08:57:47 textToQualifiedNameList second parameter