Skip site navigation (1) Skip section navigation (2)

Re: XADataSource implementation

From: Oliver Jowett <oliver(at)opencloud(dot)com>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: pgsql-jdbc(at)postgresql(dot)org, Michael Allman <msa(at)allman(dot)ms>
Subject: Re: XADataSource implementation
Date: 2005-09-12 02:00:59
Message-ID: 4324E15B.5040207@opencloud.com (view raw or flat)
Thread:
Lists: pgsql-jdbc
Heikki Linnakangas wrote:
> I've been working on the XADataSource implementation. Patch attached.
> Test case is in the separate zip file, because I couldn't get cvs to
> include it in the diff.

This looks good to me. A few comments:

- we'll need to wrap translatable strings in GT.tr() calls
- there are some places where you compare Xids by identity (==) --
shouldn't these be using .equals()?
- do we really need all of that Base64 encoder/decoder class? Seems like
we could get away with something much more simple.

-O

In response to

Responses

pgsql-jdbc by date

Next:From: Richard HuxtonDate: 2005-09-12 10:48:25
Subject: Re: BUG #1864: Strange behavoir of batches
Previous:From: Oliver JowettDate: 2005-09-11 23:13:17
Subject: Re: TimestampUtils.loadCalendar failes for interval type

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group