Skip site navigation (1) Skip section navigation (2)

GiST header cleanup

From: Neil Conway <neilc(at)samurai(dot)com>
To: pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: GiST header cleanup
Date: 2005-05-17 02:07:46
Message-ID: 428951F2.4050208@samurai.com (view raw or flat)
Thread:
Lists: pgsql-patches
This patch moves GiST implementation details from gist.h into a new 
header file, gist_private.h. gist.h should only contain APIs that are 
exposed to clients writing GiST extensions -- where possible we should 
avoid backward-incompatible changes to those APIs, so it makes sense to 
keep that API in a separate file.

Other related changes:

- pruned down the list of unnecessary includes in gist.h; as a result I 
had to add a missing #include <float.h> to contrib/cube/cube.c

- remove isAttByVal(), which is no longer used

- remove declaration of _gistdump(), which is never defined

I noticed that GISTNStrategies is defined, but never used; instead there 
is a literal "100" in include/catalog/pg_am.h. Does anyone see a reason 
to keep GISTNStrategies around? Alternatively, should pg_am.h include 
gist.h and reference GISTNStrategies instead of using "100"?

All of contrib/ continues to compile without warnings with this patch; I 
haven't tried externally maintained GiST extensions, but they may need a 
bit of #include tweaking.

Barring any objections I'll apply this later today or tomorrow.

-Neil

Attachment: gist_include_reorg-1.patch
Description: text/x-patch (15.3 KB)

Responses

pgsql-patches by date

Next:From: Neil ConwayDate: 2005-05-17 02:09:46
Subject: Re: updated GiST patch
Previous:From: Bruce MomjianDate: 2005-05-17 01:59:37
Subject: Re: Exec statement logging

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group