From: | Mark Kirkwood <markir(at)paradise(dot)net(dot)nz> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: contrib/pg_buffercache |
Date: | 2005-03-17 02:53:18 |
Message-ID: | 4238F11E.2090405@paradise.net.nz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Andrew Dunstan wrote:
>
> Mark Kirkwood wrote:
>
>
>>Andrew Dunstan wrote:
>>
>>
>>>It fixes the build error on Windows - haven't tried because i don't have
>>>time, but I know it won't work on Cygwin, because WIN32 isn't (usually)
>>>defined on Cygwin - see previous almost endless discussions.
>>>
>>
>>Yes - I recall that discussion a while ago.
>>
>>This patch should sort the issue.
>>
>>One question, should I be using defined(__MINGW32__) as opposed to
>>defined(WIN32)? I figured I didn't as in this case it is not necessary
>>to distinguish between native and cygwin.
>>
>>
>
>
> You figured correctly.
>
Oh, and thanks to your efforts with the automated build system this gets
picked up now instead of lurking till after release - great work!
cheers
Mark
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2005-03-17 03:20:34 | Re: read-only database |
Previous Message | Andrew Dunstan | 2005-03-17 01:20:10 | Re: contrib/pg_buffercache |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2005-03-17 03:20:34 | Re: read-only database |
Previous Message | Andrew Dunstan | 2005-03-17 01:20:10 | Re: contrib/pg_buffercache |