Skip site navigation (1) Skip section navigation (2)

Re: pg_autovacuum/Win32 Fixes

From: Neil Conway <neilc(at)samurai(dot)com>
To: Dave Page <dpage(at)vale-housing(dot)co(dot)uk>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: pg_autovacuum/Win32 Fixes
Date: 2005-01-22 10:13:17
Message-ID: 41F2273D.2060502@samurai.com (view raw or flat)
Thread:
Lists: pgsql-patches
Dave Page wrote:
> Theis patch supercedes *all* my earlier ones from today - apologies for
> the noise, clearly I need a beer or 3 and a few nights away from the
> laptop.

@@ -1166,7 +1166,9 @@
  		exit(0);
  #ifdef WIN32
  	case 'E':
-		args->service_dependencies = optarg;
+		ZeroMemory(deps, sizeof(deps));
+		snprintf(deps, sizeof(deps) - 2, "%s", optarg);
+		args->service_dependencies = (char *)deps;
  		break;
  	case 'I':
  		args->install_as_service++;

After googling around I can see what this code is intended to do; in the 
future a comment might be nice. Also, why not strncpy()?

Barring any objections I'll apply this patch to REL8_0_STABLE and HEAD 
on Monday.

-Neil

In response to

Responses

pgsql-patches by date

Next:From: Neil ConwayDate: 2005-01-22 12:28:52
Subject: vacuum hint on elog
Previous:From: Neil ConwayDate: 2005-01-22 05:15:45
Subject: Re: regression: pass with no default WITH OIDS

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group