Dave Page wrote:
> Theis patch supercedes *all* my earlier ones from today - apologies for
> the noise, clearly I need a beer or 3 and a few nights away from the
> laptop.

@@ -1166,7 +1166,9 @@
  		exit(0);
  #ifdef WIN32
  	case 'E':
-		args->service_dependencies = optarg;
+		ZeroMemory(deps, sizeof(deps));
+		snprintf(deps, sizeof(deps) - 2, "%s", optarg);
+		args->service_dependencies = (char *)deps;
  		break;
  	case 'I':
  		args->install_as_service++;

After googling around I can see what this code is intended to do; in the 
future a comment might be nice. Also, why not strncpy()?

Barring any objections I'll apply this patch to REL8_0_STABLE and HEAD 
on Monday.

-Neil

In response to

• pg_autovacuum/Win32 Fixes at 2005-01-21 16:09:21 from Dave Page

Responses

• Re: pg_autovacuum/Win32 Fixes at 2005-01-24 00:15:31 from Neil Conway

pgsql-patches by date

Next:	From: Neil Conway	Date: 2005-01-22 12:28:52
	Subject: vacuum hint on elog
Previous:	From: Neil Conway	Date: 2005-01-22 05:15:45
	Subject: Re: regression: pass with no default WITH OIDS