Re: [HACKERS] Need for DLLINIT in Makefile.shlib

From: Reini Urban <rurban(at)x-ray(dot)at>
To:
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>, PostgreSQL Cygwin mailing list <pgsql-cygwin(at)postgreSQL(dot)org>, PostgreSQL Win32 port list <pgsql-hackers-win32(at)postgreSQL(dot)org>
Subject: Re: [HACKERS] Need for DLLINIT in Makefile.shlib
Date: 2004-10-12 17:04:41
Message-ID: 416C0EA9.5060708@x-ray.at
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-cygwin pgsql-hackers pgsql-hackers-win32

Jason Tishler schrieb:
> On Tue, Oct 12, 2004 at 01:37:48AM +0200, Reini Urban wrote:
>>Bruce Momjian schrieb:
>>
>>>I am curious why Cygwin needs DLLINIT in Makefile.shlib, and Win32
>>>doesn't:
>>>
>>> [snip]
>>>
>>>The only difference I see is that Cygwin uses $(DLLINIT) while Win32
>>>does not. Is that correct? Why?
>>>
>>>Both set DLLINIT in their makefiles:
>>>
>>> DLLINIT = $(top_builddir)/src/utils/dllinit.o
>>>
>>>Could they be merged into a single snipped of code?
>>
>>Good point! Out of my head: I don't think that we (cygwin) don't need
>>that anymore. With newer binutils it should get autogenerated. But
>>I'll have to test before you can remove that dir.
>
>
> I concur with Reini. The DLLINIT stuff is a vestige from b20.1. FWIW,
> I attempted to remove it 3 - 4 years ago, but was unsuccessful...

I build successfully without this DLLINIT yestreday, and ran then into
the one remaining regression error, which I reported before (during
inserting some polygons in the parallel suite).

But this is for sure not related, so you can safely clean that mess up,
(remove that dir) and merge the win32 and cygwin makefile recipe.
--
Reini Urban
http://xarch.tu-graz.ac.at/home/rurban/

In response to

Responses

Browse pgsql-cygwin by date

  From Date Subject
Next Message Bruce Momjian 2004-10-12 22:19:03 Re: [HACKERS] Need for DLLINIT in Makefile.shlib
Previous Message Reini Urban 2004-10-12 16:34:43 Re: open item: tablespace handing in pg_dump/pg_restore

Browse pgsql-hackers by date

  From Date Subject
Next Message Dann Corbit 2004-10-12 17:12:01 Cannot build latest snapshot under Mingw
Previous Message Stephan Szabo 2004-10-12 16:46:20 Re: postgres vulnerability

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Bruce Momjian 2004-10-12 22:19:03 Re: [HACKERS] Need for DLLINIT in Makefile.shlib
Previous Message Reini Urban 2004-10-12 16:34:43 Re: open item: tablespace handing in pg_dump/pg_restore