Re: [HACKERS] more dirmod CYGWIN

From: Reini Urban <rurban(at)x-ray(dot)at>
To: pgsql-hackers(at)postgresql(dot)org
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] more dirmod CYGWIN
Date: 2004-09-10 18:10:50
Message-ID: 4141EE2A.2090509@x-ray.at
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-hackers-win32 pgsql-patches

Bruce Momjian schrieb:
> I have applied all parts of your patch now.

Thanks. Core builds and works fine now. (plperl IPC problems aside)

But there's are still some more minor SHLIB glitches,
which only affects contrib, because -lpgport is missing for various dll's.

SHLIB_LINK doesn't contain the libs only the paths, because they are
filtered out somewhere.
But first I want to find the real cause of the problem.
Maybe LIB is just missing a -lpgport.

$ diff -bu src/Makefile.shlib.orig src/Makefile.shlib
--- src/Makefile.shlib.orig 2004-09-03 00:06:43.000000000 +0100
+++ src/Makefile.shlib 2004-09-10 17:12:18.528655500 +0100
@@ -216,6 +216,7 @@

ifeq ($(PORTNAME), cygwin)
shlib = $(NAME)$(DLSUFFIX)
+ SHLIB_LINK += -lpgport
endif

ifeq ($(PORTNAME), win32)

$ diff -bu src/makefiles/pgxs.mk.orig src/makefiles/pgxs.mk
--- src/makefiles/pgxs.mk.orig 2004-07-30 13:26:40.000000000 +0100
+++ src/makefiles/pgxs.mk 2004-09-10 17:09:15.499748300 +0100
@@ -63,7 +63,11 @@

ifdef MODULES
override CFLAGS += $(CFLAGS_SL)
-SHLIB_LINK += $(BE_DLLLIBS)
+ifeq ($(PORTNAME), cygwin)
+ SHLIB_LINK += $(BE_DLLLIBS) $(LDFLAGS) $(LIBS) -lpgport
+else
+ SHLIB_LINK += $(BE_DLLLIBS)
+endif
endif

ifdef PG_CPPFLAGS

--
Reini Urban
http://xarch.tu-graz.ac.at/home/rurban/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Reini Urban 2004-09-10 18:19:07 Re: APR 1.0 released
Previous Message Alvaro Herrera 2004-09-10 17:21:49 Re: Update on Supporting Encryption in Postgresql

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Bruce Momjian 2004-09-10 20:54:17 Re: [HACKERS] more dirmod CYGWIN
Previous Message Harald Armin Massa 2004-09-10 17:57:09 Re: Installer crash - cannot readglobal/config_exec_params

Browse pgsql-patches by date

  From Date Subject
Next Message Mirko Tebaldi - Pubblico 2004-09-10 18:48:59 Some patches terminated
Previous Message Bruce Momjian 2004-09-10 16:16:40 Re: [HACKERS] more dirmod CYGWIN