Re: Compiling libpq with VisualC

From: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Compiling libpq with VisualC
Date: 2004-06-20 09:28:26
Message-ID: 40D558BA.4060104@pse-consulting.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-hackers-win32 pgsql-patches

Tom wrote:

>>It's there to declare struct timeval, and I'm fairly certain that diking
>>it out of the header would break things on some platforms. Where does
>>Windows define struct timeval?
>>
>>
struct timeval is defined in winsock.h under vc6.
I'm checking for _MSC_VER now.

>Agreed. We define FRONTEND when compiling libpq. Please test for that
>and send another patch.
>
>
elog.h is included in postgres.h, which is included in many
src/port/*.c. Many of them are pretty straight, not requiring any
backend specific stuff, so the attached patch will change postgres.h to
c.h for most of them.

Regards,
Andreas

Attachment Content-Type Size
include-cleanup.patch text/plain 5.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Henner Zeller 2004-06-20 12:09:29 JDBC prepared statements: actually not server prepared
Previous Message Dave Page 2004-06-20 08:32:33 Re: Cannot initdb in cvs tip

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Magnus Hagander 2004-06-20 18:53:28 Data directory with trailing [back]slash
Previous Message Andrew Dunstan 2004-06-20 07:12:19 Re: Cannot initdb in cvs tip

Browse pgsql-patches by date

  From Date Subject
Next Message Laurent Ballester 2004-06-20 09:29:34 Re: eventlog fix
Previous Message Dave Page 2004-06-20 08:32:33 Re: Cannot initdb in cvs tip