Skip site navigation (1) Skip section navigation (2)

Re: clang's static checker report.

From: Greg Stark <gsstark(at)mit(dot)edu>
To: Grzegorz Jaskiewicz <gj(at)pointblue(dot)com(dot)pl>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alex Hunsaker <badalex(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: clang's static checker report.
Date: 2009-08-29 16:35:35
Message-ID: 407d949e0908290935j19167061oa83776b00a264304@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
We still have things like this showing "division by zero":

Assert(activeTapes > 0);
1913		slotsPerTape = (state->memtupsize - state->mergefirstfree) / activeTapes;


It looks like if you marked ExceptionalCondition() as never returning
then it should hide this.


-- 
greg
http://mit.edu/~gsstark/resume.pdf

In response to

Responses

pgsql-hackers by date

Next:From: Grzegorz JaskiewiczDate: 2009-08-29 16:47:42
Subject: Re: clang's static checker report.
Previous:From: Grzegorz JaskiewiczDate: 2009-08-29 16:13:50
Subject: Re: clang's static checker report.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group