Skip site navigation (1) Skip section navigation (2)

Re: Re: [COMMITTERS] pgsql: Add connection messages for streaming replication.

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Add connection messages for streaming replication.
Date: 2010-03-24 11:30:50
Message-ID: 3f0b79eb1003240430l10182c67qbbaa25610afebef8@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Wed, Mar 24, 2010 at 8:22 PM, Heikki Linnakangas
<heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> but I don't see any mention of that in the docs. How about:
>
> *** client-auth.sgml    24 Mar 2010 09:44:06 +0200      1.134
> --- client-auth.sgml    24 Mar 2010 13:21:16 +0200
> ***************
> *** 77,84 ****
>     a set of records, one per line. Blank lines are ignored, as is any
>     text after the <literal>#</literal> comment character. A record is made
>     up of a number of fields which are separated by spaces and/or tabs.
> !    Fields can contain white space if the field value is quoted. Records
> !    cannot be continued across lines.
>    </para>
>
>    <para>
> --- 77,87 ----
>     a set of records, one per line. Blank lines are ignored, as is any
>     text after the <literal>#</literal> comment character. A record is made
>     up of a number of fields which are separated by spaces and/or tabs.
> !    Fields can contain white space if the field value is quoted.
> !    Quoting one of the keywords in database or username field (e.g "all"
> !    or "replication") makes the name lose its special character, and just
> !    match a database or username with that name. Records cannot be
> !    continued across lines.
>    </para>

+1

>> That probably tips the balance towards having the alternate wording:
>> LOG:  replication connection authorized: user=foo
>
> +1

+1

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

In response to

Responses

pgsql-hackers by date

Next:From: Gokulakannan SomasundaramDate: 2010-03-24 11:33:08
Subject: Re: Performance Improvement for Unique Indexes
Previous:From: Fujii MasaoDate: 2010-03-24 11:23:15
Subject: PHONY targets in Makefile.global.in

pgsql-committers by date

Next:From: Simon RiggsDate: 2010-03-24 11:52:10
Subject: Re: Re: [COMMITTERS] pgsql: Add connection messages for streaming replication.
Previous:From: Heikki LinnakangasDate: 2010-03-24 11:22:47
Subject: Re: Re: [COMMITTERS] pgsql: Add connection messages for streaming replication.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group