Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] statement level trigger causes pltcl, plpython

From: Joe Conway <mail(at)joeconway(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] statement level trigger causes pltcl, plpython
Date: 2003-08-04 19:46:43
Message-ID: 3F2EB823.50509@joeconway.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Tom Lane wrote:
> BTW, one other stylistic nit: I don't think comments like
> 
> 		/* internal error */
> 		elog(ERROR, "unrecognized OP tg_event: %u", tdata->tg_event);
> 
> are really necessary.  In the brave new ereport world, any elog(ERROR)
> call is an internal error by definition --- if it isn't, you should be
> using ereport.  So the use of elog is sufficient documentation.  IMHO
> anyway.

Yeah, I agree. During the conversion, I did that mostly to show that it 
was a conscious decision. Going forward, every new elog (versus ereport) 
*is* a conscious decision, or at least should be.

Joe



In response to

pgsql-hackers by date

Next:From: Tom LaneDate: 2003-08-04 20:12:17
Subject: Re: Passing server_encoding to the client is not future-proof
Previous:From: Alvaro HerreraDate: 2003-08-04 19:35:58
Subject: Re: problem with cache

pgsql-patches by date

Next:From: Tom LaneDate: 2003-08-04 21:00:21
Subject: Re: Patch for select() -> poll() in libpq
Previous:From: Tom LaneDate: 2003-08-04 18:43:23
Subject: Re: [HACKERS] statement level trigger causes pltcl, plpython SIGSEGV

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group