Skip site navigation (1) Skip section navigation (2)

Re: Patch to remove connection hook and JDK 1.3 dependencies

From: Joseph Shraibman <jks(at)selectacast(dot)net>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Barry Lind <barry(at)xythos(dot)com>, pgsql-jdbc(at)postgresql(dot)org
Subject: Re: Patch to remove connection hook and JDK 1.3 dependencies
Date: 2001-07-09 22:56:57
Message-ID: 3B4A36B9.EBC8A057@selectacast.net (view raw or flat)
Thread:
Lists: pgsql-jdbcpgsql-patches
Joseph Shraibman wrote:
> 
<snip>

OK I looked at ConnectionHook in the cvs and there is obviously code
there to close the connections, but where is the code that calls
ConnectionHook.open()?  That's probably the problem.

Also a Vector should be used instead of an ArrayList because there could
be multiple threads accessing the jdbc driver at the same time.  It
could be that open() and close() are only supposed to be called from
code that is locked anyway but I can't verify that.

Also I'm wondering why there is a ConnectionHook class at all.  It seems
to me it would be better to have this stuff in Connection itself and we
wouldn't have to do that strange workaround of calling init().

If I can connect to the cvs I'll try and code it.


-- 
Joseph Shraibman
jks(at)selectacast(dot)net
Increase signal to noise ratio.  http://www.targabot.com

In response to

pgsql-patches by date

Next:From: Joseph ShraibmanDate: 2001-07-09 23:48:41
Subject: Re: Backups WAS: 2 gig file size limit
Previous:From: Barry LindDate: 2001-07-09 22:44:50
Subject: Re: [PATCH] Cleanup of JDBC character encoding

pgsql-jdbc by date

Next:From: Joseph ShraibmanDate: 2001-07-09 23:48:41
Subject: Re: Backups WAS: 2 gig file size limit
Previous:From: Barry LindDate: 2001-07-09 22:44:50
Subject: Re: [PATCH] Cleanup of JDBC character encoding

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group