Re: Error handling in ODBC

Tibor Laszlo wrote:
>
> Hiroshi Inoue writes:
>
> > Recently I found the case that NOTICE causes an error in ODBC
> > while examining Kristis' error report.
> >
> > It seems that NOTICE had never been the cause of SQL_ERROR
> > before Zoltan's change about a year ago. Before his change *NOTICE*
> > only caused a PGRES_NONFATAL_ERROR and SC_execute()
> > returned SQL_SUCCESS_WITH_INFO. However currently *ERROR*
> > also causes a PGRES_NONFATAL_ERROR and SC_Execute()
> > returns SQL_ERROR.
> > Why was this changed ?
>
> Zoltan changed the driver because nobody else did it. As I recall, we asked this
> list to correct the driver to work correctly with 7.0 pre releases with RI, but
> we received no answers. We tried to correct the problem for ouselves. It worked.
> But later we were asked to share the patch. Lastly it used to commit the main
> CVS by sombody else but we asked this list again to werify the modifycatons by
> sombody knowing something about ODBC and the current driver.
>

Unfortunately we have no ODBC maintainer.

> > I'd like to put it back if there's no reason.
>
> I think it should be corrected. But if I rmember correctly, the patch was for
> report RI violatoions to the app, and these errors comes as NOTICEs not ERRORs.
> May I wrong? Is it the case now?
>

I don't know how it came about. ISTM the old driver didn't
take 'E' after 'C' response into account and failed to report
RI violation errors by ignoring the 'E'. The 'E' correponds
to an ERROR not a NOTICE.

regards,
Hiroshi Inoue