Skip site navigation (1) Skip section navigation (2)

Re: vacuum as flags in PGPROC

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Heikki Linnakangas <heikki(at)enterprisedb(dot)com>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: vacuum as flags in PGPROC
Date: 2007-10-24 15:55:17
Message-ID: 3990.1193241317@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Heikki Linnakangas <heikki(at)enterprisedb(dot)com> writes:
> Alvaro Herrera wrote:
>> I did it that way (i.e. added locking) and then realized that it
>> shouldn't really be a problem, because the only one who can be setting
>> vacuum flags is the process itself.  Other processes can only read the
>> flags.

> It would still be a problem if there was any other fields that were
> updated by other processes, adjacent to the vacuum flags. I don't think
> that's the case, however.

Well, that may not be the case today, but it still seems like an
assumption that will come back to bite us someday.  And can you imagine
trying to debug a misbehavior like that?  It's really not worth the risk,
given how seldom these flags will be changed.

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: Heikki LinnakangasDate: 2007-10-24 15:57:58
Subject: Re: vacuum as flags in PGPROC
Previous:From: Alvaro HerreraDate: 2007-10-24 15:41:00
Subject: Re: vacuum as flags in PGPROC

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group