Skip site navigation (1) Skip section navigation (2)

Re: BUG #1490: contrib .sql.in sed command bogus

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Alexis Wilke" <alexis(at)m2osw(dot)com>
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #1490: contrib .sql.in sed command bogus
Date: 2005-02-22 00:16:56
Message-ID: 3835.1109031416@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-bugs
"Alexis Wilke" <alexis(at)m2osw(dot)com> writes:
> Inside pgxs.mk I had to change the $$libdir into $(libdir ) to get the
> proper path in the final .sql file:
 

> ifneq (,$(MODULES)$(MODULE_big))
> %.sql: %.sql.in
> 	sed 's,MODULE_PATHNAME,$(libdir)/$*,g' $< >$@
> endif

This is not correct --- the substitution is supposed to be literally
"$libdir", and so the makefile is correct as-is.  (I'm not sure why we
still bother with doing the sed conversion at all, except that if we
removed it you can be sure we'd think of some other thing we needed it
for ;-))

			regards, tom lane

In response to

Responses

pgsql-bugs by date

Next:From: Tom LaneDate: 2005-02-22 00:20:42
Subject: Re: BUG #1491: Getting an "undefined symbol" when loading contrib mod.
Previous:From: Barry BrownDate: 2005-02-21 22:57:40
Subject: BUG #1497: Default permissions allow any user to create objects in any database

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group