Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] quote_literal with NULL

From: "Brendan Jurd" <direvus(at)gmail(dot)com>
To: "Simon Riggs" <simon(at)2ndquadrant(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] quote_literal with NULL
Date: 2007-10-15 05:39:35
Message-ID: 37ed240d0710142239h6096f42s423d80ea297c0a44@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
On 10/15/07, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> > I did make a version of the patch which has the pg_proc entries for
> > quote_literal and quote_nullable both pointing to the same internal
> > function.  I thought this was a tidier solution, but it failed
> > regression test #5 in opr_sanity; apparently two entries in pg_proc
> > can't have the same prosrc and differing proisstrict?
>
> Sanity prevails, I guess. :-)
>

I'm all for the prevalance of sanity, but I'm not really clear on what
about the above scenario is not sane.

Suspect I'm missing something about the workings of pg_proc, but from
over here it seems like having a strict and a non-strict version of
the same function would be okay.  As long as the internal function is
rigged to handle null input properly, what's the problem?

It's only tangential to the patch itself, and I'm not challenging the
regression test.  Just curious about it.

Cheers,
BJ

In response to

Responses

pgsql-hackers by date

Next:From: Michael PaesoldDate: 2007-10-15 06:18:33
Subject: Re: rolcanlogin vs. the flat password file
Previous:From: Simon RiggsDate: 2007-10-15 05:19:56
Subject: Re: [HACKERS] quote_literal with NULL

pgsql-patches by date

Next:From: Heikki LinnakangasDate: 2007-10-15 09:31:26
Subject: Re: Updated patch for tsearch contrib examples
Previous:From: Simon RiggsDate: 2007-10-15 05:19:56
Subject: Re: [HACKERS] quote_literal with NULL

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group