Skip site navigation (1) Skip section navigation (2)

Re: WAL: O_DIRECT and multipage-writer

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: ITAGAKI Takahiro <itagaki(dot)takahiro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: WAL: O_DIRECT and multipage-writer
Date: 2005-01-25 15:56:38
Message-ID: 3763.1106668598@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
ITAGAKI Takahiro <itagaki(dot)takahiro(at)lab(dot)ntt(dot)co(dot)jp> writes:
> I resend the patch with diff -c.

What does XLOG_EXTRA_BUFFERS accomplish?

Also, I'm worried that you broke something by not updating
Write->curridx immediately in XLogWrite.  There certainly isn't going
to be any measurable performance boost from keeping that in a local
variable, so why take any risk?

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Alvaro HerreraDate: 2005-01-25 15:57:02
Subject: Re: how to add a new column in pg_proc table
Previous:From: noman naeemDate: 2005-01-25 15:44:18
Subject: how to add a new column in pg_proc table

pgsql-patches by date

Next:From: Matthew T. O'ConnorDate: 2005-01-25 16:20:53
Subject: Re: pg_autovacuum Win32 Service startup delay
Previous:From: Mahmoud TaghizadehDate: 2005-01-25 13:35:43
Subject: add collation support to postgresql

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group