Re: WAL: O_DIRECT and multipage-writer

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: ITAGAKI Takahiro <itagaki(dot)takahiro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: WAL: O_DIRECT and multipage-writer
Date: 2005-01-25 15:56:38
Message-ID: 3763.1106668598@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

ITAGAKI Takahiro <itagaki(dot)takahiro(at)lab(dot)ntt(dot)co(dot)jp> writes:
> I resend the patch with diff -c.

What does XLOG_EXTRA_BUFFERS accomplish?

Also, I'm worried that you broke something by not updating
Write->curridx immediately in XLogWrite. There certainly isn't going
to be any measurable performance boost from keeping that in a local
variable, so why take any risk?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2005-01-25 15:57:02 Re: how to add a new column in pg_proc table
Previous Message noman naeem 2005-01-25 15:44:18 how to add a new column in pg_proc table

Browse pgsql-patches by date

  From Date Subject
Next Message Matthew T. O'Connor 2005-01-25 16:20:53 Re: pg_autovacuum Win32 Service startup delay
Previous Message Mahmoud Taghizadeh 2005-01-25 13:35:43 add collation support to postgresql