Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Clean up the #include mess a little.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jeremy Drake <pgsql(at)jdrake(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org, Bruce Momjian <bruce(at)momjian(dot)us>
Subject: Re: pgsql: Clean up the #include mess a little.
Date: 2011-09-04 06:25:30
Message-ID: 3639.1315117530@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Jeremy Drake <pgsql(at)jdrake(dot)com> writes:
> Well, this commit seems to have fixed whatever problem mongoose was
> having.  Hooray, I guess.
> http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=mongoose&dt=2011-09-04%2005%3A45%3A02

Yeah, I just saw that.  So that confirms (AFAICT) that the inclusion
of walsender.h in xlog.h was what broke it ... but why?  As I said
before, I don't like black magic.

			regards, tom lane

In response to

pgsql-hackers by date

Next:From: Jeremy DrakeDate: 2011-09-04 07:13:53
Subject: Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge
Previous:From: Jeremy DrakeDate: 2011-09-04 06:20:41
Subject: Re: pgsql: Clean up the #include mess a little.

pgsql-committers by date

Next:From: Jeremy DrakeDate: 2011-09-04 07:13:53
Subject: Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge
Previous:From: Jeremy DrakeDate: 2011-09-04 06:20:41
Subject: Re: pgsql: Clean up the #include mess a little.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group