Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] postgres init script things solved

From: "Thomas G(dot) Lockhart" <lockhart(at)alumni(dot)caltech(dot)edu>
To: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
Cc: cbalciza(at)mail(dot)geocities(dot)com, pgsql-hackers(at)hub(dot)org
Subject: Re: [HACKERS] postgres init script things solved
Date: 1998-04-28 02:02:05
Message-ID: 3545389D.B5AF9173@alumni.caltech.edu (view raw or flat)
Thread:
Lists: pgsql-hackers
> > > > The postgresql-?.?.?/contrib/linux/postgres.init is meant to start your
> > > > postmaster at boot time and stop it at halt/reboot. Excelent.
> > > > But it is made for postgres account running tcsh. I know nothing about tchs
> > > > and my postgres account defaults to bash. So (thanks to Steve "Stevers!"
> > > > Coile) I changed it to bash:
> >
> > OK, but _I_ don't run bash. So someone else is now maintaining this
> > file? Why didn't we keep both forms in the file, with one commented out?
> > What are we trying to accomplish here??
> 
> bash/sh is the standard, expecially because the top of the file has
> #!/bin/sh.

Sorry, the top of the init script and the postgres shell aren't related.
The init script is run at startup out of the root account. The line
which was changed is run under the postgres account, which can have a
different shell from the root shell.

imho it is not a step forward to break some code to help others. How
about asking the person submitting the patch to document what they did
differently? The original code at least had a line saying what had to be
changed; the patch doesn't fix the comment or suggest how to support an
alternate shell.

Or, have two files in contrib, postgres.init.tcsh and postgres.init. Or
at least something which is a step forward rather than sideways...

                       - Tom

In response to

Responses

pgsql-hackers by date

Next:From: Vadim B. MikheevDate: 1998-04-28 02:04:48
Subject: Re: [INTERFACES] Re: [HACKERS] New Driver and Unique Indexes
Previous:From: Vadim B. MikheevDate: 1998-04-28 02:01:25
Subject: Re: [QUESTIONS] Postgres still dying on insert

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group