On Fri, Oct 31, 2008 at 07:48, David Fetter <david(at)fetter(dot)org> wrote:
> Please find attached a patch which works in PL/Perl, the work having
> been done by Andrew (RhodiumToad) Gierth. It's not clear to me how
> this would be generally surface-able to SQL, though. Any ideas?
I was assigned to review this. A few comments beside the ones Alavaro
and Tom pointed out...
select * from dblink('select * from foo');
segfaults due to rsi in dblink_record_internal() never being
initialized. You probably know that though and are just trying to
show how dblink could use it...
select * from dblink('select * from foo where..') s(a) where ...;
seems like it will fail (due to the 2 where clauses) with a strange
error message (though its hard to tell without documentation :))
Why the where clause and not table/joins/target list etc?
Maybe instead of having this for PL's we should just keep the part
that composes the qualifiers into strings (rsinfo_get_qual_str()) so
that only contrib modules can use it? And for now dblink will just be
the only user? Or what exactly is the use case for PL languages to
have it? SQL/MED ?
I started following http://wiki.postgresql.org/wiki/Reviewing_a_Patch.
But it felt useless until you make Tom and Alavaro happy :) Or at
least I have a patch that I can play with :)
In response to
pgsql-hackers by date
|Next:||From: Alex Hunsaker||Date: 2008-11-04 03:08:06|
|Subject: Re: pre-MED|
|Previous:||From: Robert Haas||Date: 2008-11-04 02:47:38|
|Subject: Re: [PATCH] Extending pg_class info + more flexible TOAST chunk size|