Skip site navigation (1) Skip section navigation (2)

Re: HOT patch - version 11

From: "Pavan Deolasee" <pavan(dot)deolasee(at)gmail(dot)com>
To: "Heikki Linnakangas" <heikki(at)enterprisedb(dot)com>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: HOT patch - version 11
Date: 2007-08-02 07:33:08
Message-ID: 2e78013d0708020033r64bb7522ge3221a2c33fd4eab@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
On 8/2/07, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com> wrote:
>
>
>
> On 8/2/07, Heikki Linnakangas <heikki(at)enterprisedb(dot)com> wrote:
> >
> > Maybe a nicer
> > solution would be to have another version of ConditionalLockBuffer with
> > three different return values: didn't get lock, got exclusive lock, or
> > got cleanup lock.
>
>
>
> Thats a good idea. I shall do that.
>
>

On a second thought, I feel its may not be such a good idea to change
the ConditionalLockBuffer return value. "boolean" is the most natural
way. And we don't save anything in terms on BufHdr locking.

So may be should just have two different functions and do the
BufferIsLockedForCleanup check immediately after acquiring the
exclusive lock.


Thanks,
Pavan

-- 
Pavan Deolasee
EnterpriseDB     http://www.enterprisedb.com

In response to

pgsql-hackers by date

Next:From: Heikki LinnakangasDate: 2007-08-02 07:52:51
Subject: Re: GIT patch
Previous:From: Pavan DeolaseeDate: 2007-08-02 06:53:26
Subject: Re: HOT patch - version 11

pgsql-patches by date

Next:From: Andrew DunstanDate: 2007-08-02 07:56:25
Subject: Re: enable logging of start time/cookie for all backend processes
Previous:From: Pavan DeolaseeDate: 2007-08-02 06:53:26
Subject: Re: HOT patch - version 11

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group