Skip site navigation (1) Skip section navigation (2)

Re: Latest version of Hot Standby patch: unexpected error querying standby

From: Greg Stark <greg(dot)stark(at)enterprisedb(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: Simon Riggs <simon(at)2ndQuadrant(dot)com>, Mark Kirkwood <markir(at)paradise(dot)net(dot)nz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Latest version of Hot Standby patch: unexpected error querying standby
Date: 2009-01-04 16:40:21
Message-ID: 2BCDDAF6-A81B-4EC6-8A4E-AB1DE16C4801@enterprisedb.com (view raw or flat)
Thread:
Lists: pgsql-hackers
What I ifind interesting about this is that whereas I had been  
concerned that adding hot standby late in the development cycle might  
be destabilize the tree and add lots of time to the release cycle it  
seems having it might actually increase our ability to see problems in  
the recovery code which was previously quite hard to test.

-- 
Greg


On 4 Jan 2009, at 09:59, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com 
 > wrote:

> Heikki Linnakangas wrote:
>> I can reproduce that too with CVS HEAD, so it's clearly a bug. I  
>> probably introduced it with the recent smgr changes; I'll try to  
>> hunt it down.
>
> Now that was an embarrassingly simple bug:
>
> --- a/src/backend/catalog/storage.c
> +++ b/src/backend/catalog/storage.c
> @@ -106,7 +106,7 @@ RelationCreateStorage(RelFileNode rnode, bool  
> istemp)
>    srel = smgropen(rnode);
>    smgrcreate(srel, MAIN_FORKNUM, false);
>
> -    if (istemp)
> +    if (!istemp)
>    {
>        /*
>         * Make an XLOG entry showing the file creation.  If we  
> abort, the file
>
> Fixed, as well as the same bug in RelationTruncate. Thanks for  
> report, I'll keep this brown paper bag on for a few days...
>
> -- 
>  Heikki Linnakangas
>  EnterpriseDB   http://www.enterprisedb.com
>
> -- 
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers

In response to

pgsql-hackers by date

Next:From: Tom LaneDate: 2009-01-04 17:14:38
Subject: Re: parallel restore
Previous:From: Stephen FrostDate: 2009-01-04 16:18:34
Subject: Re: New patch for Column-level privileges

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group