Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Mon, Feb 15, 2010 at 10:02 AM, Alvaro Herrera
> <alvherre(at)commandprompt(dot)com> wrote:
>> I notice that the new plperl error messages are somewhat out of line of
>> our usual style:
>> errmsg("while executing utf8fix"),
>> errdetail("%s", strip_trailing_ws(SvPV_nolen(ERRSV))) ));
>> I think the errdetail field should really be errmsg, and the errdetail
>> should be errcontext.
>> There are several messages like this.
>> Should this be fixed?
Yes. Message style policing is exactly the kind of thing we should be
doing now. While you're at it, get rid of the
errcode(ERRCODE_INTERNAL_ERROR) if you can't find a better errcode ---
that's the default anyway.
regards, tom lane
In response to
pgsql-hackers by date
|Next:||From: Robert Haas||Date: 2010-02-15 16:08:23|
|Subject: Re: TCP keepalive support for libpq|
|Previous:||From: Tom Lane||Date: 2010-02-15 16:00:45|
|Subject: Re: TCP keepalive support for libpq |