Re: [PATCHES] Cleaning up unreferenced table files

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCHES] Cleaning up unreferenced table files
Date: 2005-05-11 04:02:34
Message-ID: 29801.1115784154@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
> On Tue, 10 May 2005, Bruce Momjian wrote:
>> The current code is nice and localized and doesn't add any burden on our
>> existing code, which is already complicated enough. I think we either
>> fix checkfiles.c, or we remove it and decide it isn't worth checking for
>> unrefrenced files.

> Let's pull the patch for now.

FWIW, I was OK with the idea of adding something similar to the given
patch to find out whether we had a problem or not. With sufficient
evidence that lost files are a big problem, I'd be in favor of a
mechanism of the kind proposed in Heikki's latest messages. The
disconnect for me at the moment is that there's no evidence to justify
that amount of effort/risk. A startup-time patch would have provided
that evidence, or else have proven that it's not worth spending more
time on.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2005-05-11 04:28:49 Re: Oracle Style packages on postgres
Previous Message Bruce Momjian 2005-05-11 03:44:38 Re: lastval()

Browse pgsql-patches by date

  From Date Subject
Next Message John Hansen 2005-05-11 04:08:16 Re: lastval()
Previous Message Bruce Momjian 2005-05-11 03:45:23 Re: lastval()