Skip site navigation (1) Skip section navigation (2)

Re: xlog location arithmetic

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Euler Taveira de Oliveira <euler(at)timbira(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: xlog location arithmetic
Date: 2012-03-09 15:37:42
Message-ID: 29655.1331307462@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Fri, Mar 9, 2012 at 9:55 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Actually ... now that I look at it, isn't it completely bogus to be
>> using numeric for the result of pg_xlog_location_diff?

> rhaas=# select pg_xlog_location_diff('ffffffff/0', '0/0')::int8;
> ERROR:  bigint out of range

Oh ... I see my mistake.  I was looking at this:

	/*
	 * result = XLogFileSize * (xlogid1 - xlogid2) + xrecoff1 - xrecoff2
	 */

and confusing XLogFileSize with XLogSegSize.  Not the best choice of
names.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2012-03-09 15:41:53
Subject: Re: pg_upgrade and umask
Previous:From: Kohei KaiGaiDate: 2012-03-09 15:36:41
Subject: Re: elegant and effective way for running jobs inside a database

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group