Skip site navigation (1) Skip section navigation (2)

Re: feature request - datum_compute_size and datum write_should be public

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, heikki(dot)linnakangas(at)iki(dot)fi, Jeff Davis <pgsql(at)j-davis(dot)com>
Subject: Re: feature request - datum_compute_size and datum write_should be public
Date: 2012-02-01 06:29:43
Message-ID: 29098.1328077783@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> writes:
> I looked to sources and I found a some useful routines for people who
> write extensions and probably PL too.

> There are datum_compute_size and datum_write from range_types.c. These
> routines can be used in PL libs and maybe in other places.

> Should be these routines moved to varlena.c and be public?

Why?  It is not common for types to contain other types, and it
certainly isn't likely to happen without needing lots of other
infrastructure --- the existing examples are arrays, records, and
rangetypes, and all of those come with lots of baggage.  And there
are a number of choices in those functions that are pretty specific to
rangetypes, as illustrated by the fact that they're not already sharing
code with either arrays or records.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Pavel StehuleDate: 2012-02-01 06:45:51
Subject: Re: feature request - datum_compute_size and datum write_should be public
Previous:From: Pavel StehuleDate: 2012-02-01 06:17:31
Subject: feature request - datum_compute_size and datum write_should be public

Privacy Policy | About PostgreSQL
Copyright © 1996-2013 The PostgreSQL Global Development Group