Re: Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)
Date: 2009-08-11 19:51:33
Message-ID: 28876.1250020293@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Andrew Dunstan escribi:
>> Here's the extract attached. I replace tabs with a literal '\t' so
>> I could see what it was doing. I can't make much head or tail of it
>> either.

> pgindent uses entab/detab, which counts spaces and replaces them with
> tabs. It is wildly undocumented. See src/tools/entab

What surprises me is that it seems to be changing lines that have been
there for quite some time. Bruce, have you been changing pgindent
underneath us?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2009-08-11 20:16:04 pgsql: Refactor some $(JADE.tex.call)s
Previous Message User Fxjr 2009-08-11 19:46:51 npgsql - Npgsql2: Fixed bug when trying to retrieve a date value with

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2009-08-11 19:59:48 Re: machine-readable explain output v4
Previous Message Kevin Grittner 2009-08-11 19:49:48 Re: "Hot standby"?