Skip site navigation (1) Skip section navigation (2)

Re: Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)
Date: 2009-08-11 19:51:33
Message-ID: 28876.1250020293@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Andrew Dunstan escribi:
>> Here's the extract attached.  I replace tabs with a literal '\t' so
>> I could see what it was doing. I can't make much head or tail of it
>> either.

> pgindent uses entab/detab, which counts spaces and replaces them with
> tabs.  It is wildly undocumented.  See src/tools/entab

What surprises me is that it seems to be changing lines that have been
there for quite some time.  Bruce, have you been changing pgindent
underneath us?

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Andrew DunstanDate: 2009-08-11 19:59:48
Subject: Re: machine-readable explain output v4
Previous:From: Kevin GrittnerDate: 2009-08-11 19:49:48
Subject: Re: "Hot standby"?

pgsql-committers by date

Next:From: Alvaro HerreraDate: 2009-08-11 20:16:04
Subject: pgsql: Refactor some $(JADE.tex.call)s
Previous:From: User FxjrDate: 2009-08-11 19:46:51
Subject: npgsql - Npgsql2: Fixed bug when trying to retrieve a date value with

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group